Correct parenthesisation in generic Show #10
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of issues with the
gshowderived in this moduleIgshowsPrecinstead ofgshowdirectly)I appreciate that this package is for "simple basic examples" rather than "fully working but less simple code" but I would question the value of the simple examples if they're just completely wrong for the stated purpose. I think this PR isn't too much more complex than what went before and I think it would be useful to have a real example of
Generics.SOPthat people can drop in to code that's expected to work.Anyway, if you really don't want to incorporate this, no hard feelings. I can always create a new package.
Data types
Before
After